-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sqlsmith): enable sub-query generation #4216
Conversation
Need to solve this first #4215, |
Codecov Report
@@ Coverage Diff @@
## main #4216 +/- ##
==========================================
- Coverage 74.32% 74.32% -0.01%
==========================================
Files 844 844
Lines 122407 122407
==========================================
- Hits 90985 90983 -2
- Misses 31422 31424 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM.
@kwannoel @neverchanje , I have made the changes to the lateral_contexts already. It is ready for approval. |
* Solve bug 1 * Resolve error * Resolved Comments * Undo enable agg * remove lateralcontexts * Fix formatting * Control recursion Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
./risedev check
(or alias,./risedev c
)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Refer to a related PR or issue link (optional)
related to #3935
close #4215